Improve Astro style HMR for imported styles #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1848080 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
reviewed
Feb 20, 2024
|
@ematipico I added some comments since your last review explaining some things better. Appreciate if you can take another look! |
ematipico
approved these changes
Feb 22, 2024
matthewp
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #9262
This PR removes some hacks needed before Vite 5.1. Now with Vite 5.1, we can register style dependencies directly to the Astro style virtual module instead, e.g.
/src/pages/index.astro?astro&type=style&index=0&lang.css. We can more better prevent circular deps that caused vitejs/vite#15585 and some tailwind issues.The result is that CSS HMR should be more granular and simpler, but in this PR I had to leverage
astroFileToCompileMetadatastill in HMR to invalidate the metadata correctly, so that the Astro style virtual module can re-compile the new CSS.Testing
Added a new test and made sure HMR don't refresh for styles.
Docs
m/a. bug fix.