WIP: vite runtime api #10091
Closed
WIP: vite runtime api #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f42edb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alexanderniebuhr
force-pushed
the
nbhr/vite_runtime_api
branch
from
907b3ce to
fff27ce
Compare
github-actions
bot
removed
pkg: svelte
alexanderniebuhr
force-pushed
the
nbhr/vite_runtime_api
branch
2 times, most recently
from
cc4abb2 to
a5decba
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
!preview vite-runtime-api |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
alexanderniebuhr
force-pushed
the
nbhr/vite_runtime_api
branch
from
a5decba to
5f42edb
Compare
|
!preview vite-runtime-api |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
Since this is postponed until we see how the API shapes and it might be a bigger refactor, since we already discover on Discord, I'll close this PR. We can either reopen, create a new one, or decide later what to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: After some Discord discussions, we have a better understanding, my goal is to get a
workerdruntime implement, without caring about backward compatibility &or a default node runtime. If we have a POC forworkerd, we can decide if we put this behind an external flag, which disables current behavior and only allows custom runtime, or if we want to investigate some more time how to get both running in parallel and automatically choosing the right oneUPDATE: After some exploration, I'm pretty sure this is not the correct approach. (see messages following: https://discord.com/channels/830184174198718474/845430950191038464/1212079358701731880)
Changes
server.ssrLoadModulehttps://vitejs.dev/guide/api-vite-runtimewokerdif using the Cloudflare adapter, which would make sure that dev has the same runtime as prod, and users won't face issues with incompatible or different behaviour between dev & prod.a) https://github.com/sapphi-red/vite-envs/blob/main/examples/cloudflare-pages/vite.config.ts#L17-L18
b) https://github.com/dario-piotrowicz/vite-runtime-5.1-experimentations/blob/a2d2d9aabbce5f058f530710730a1fdf5773eb80/examples/basic-handler/vite.config.js#L40
c) Back to Vite 🎉 Shopify/hydrogen#1728
d) https://github.com/hi-ogawa/vite-plugins/tree/ba5d995046cffc0fd368dd3c3a4d05f9d2db29dc/packages/vite-node-miniflare
Testing
Docs