Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): don't consider URLs that start with the name of the defaut locale #10016

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes #10005

The logic that checks the presence of the default locale was very broad and poor. This new logic should be more robust.

Testing

I added new test cases

Docs

N/A

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: 0511c93

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 7, 2024
@ematipico ematipico merged commit 037e4f1 into main Feb 7, 2024
13 checks passed
@ematipico ematipico deleted the fix/clash-of-default-locale-plt-1549 branch February 7, 2024 14:42
@astrobot-houston astrobot-houston mentioned this pull request Feb 7, 2024
@janl
Copy link

janl commented Feb 7, 2024

heads up that we had already fixed this here #9983 and now have nothing to show for but wasted time. Not very encouraging to ever contribute again here. ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic URI starting with /{AstroConfig.i18n.defaultLocale} will result in a browser 404
3 participants