Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support strict() on content collection schemas when slug is present #10003

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Feb 6, 2024

Changes

Resolves #8871

Support strict() extension on content collection schemas when slug is present. Before, we would accidentally parse slug with the user's content schema.

Testing

  • Add .strict() to the content collection slug fixture

Docs

N/A

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: bf6cea7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 6, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for following up on this one @bholmesdev 🚀

Co-authored-by: Chris Swithinbank <[email protected]>
@bholmesdev bholmesdev merged commit ce42833 into main Feb 7, 2024
4 checks passed
@bholmesdev bholmesdev deleted the fix/strict-with-slug branch February 7, 2024 12:26
@astrobot-houston astrobot-houston mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content collections doesn't allow .strict()
3 participants