-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces in project path break Markdoc integration #8164
Comments
Thanks for bringing this up! It's probably going to be difficult to diagnose it from your real project that you linked. Could you create a minimal reproduction? |
Hello @suhaylmv. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with |
@lilnasy |
That's odd. I think the problem is the OS. Now I'm on Elementary OS (debian based), but before when I used Arch I never had such issues. I had a fuckton of other problems too because of Elementary. Distro hopping is never going to end). Thank you for help! |
I made a fresh install of pop os and I'm having the same problem. Idk what to do |
Ok I found a solution. For some reason when the project folder is inside an external hdd drive and the project uses markdoc, gives this error. I would suggest trying the same on other machines to see if the same error occurs. If it does, then maybe it's worth adding the information to the troubleshooting page in the documentation. |
You also seem to have a space in your project path, could that be the issue? |
Where? |
Good first issue!This is an opportunity for astro users to learn about how astro works by fixing a small but real bug. You can expect to get help setting up the dev environment, and understanding the project structure in the #dev channel of our discord: https://astro.build/chat. If you have already been contributing for a while, consider guiding an enthusiastic newcomer. What's the bug?You can reproduce it by creating a new project using the What's going wrong here?The cause of the issue is a space in the path. Astro config stores most paths as URL objects. Part of URL encoding is using Where do I start looking?The markdoc integration uses the Astro config (with URLs) here. |
Hello @lilnasy, I actually already have a fix for this thanks to your suggestions, but I also wanted to add a test case for this scenario. Do you think it could be valuable? If yes, proper tests would be of "render", "render html" and "variables" categories, is that correct? Thank you in advance! |
Thanks for looking into it! And yes, those categories sound appropriate. |
Just linked this issue to the next release so GitHub will display what release the fix is included in! |
Looks like GitHub didn't automatically close this. Fixed in #8759 |
What version of
astro
are you using?2.10.12
Are you using an SSR adapter? If so, which one?
No
What package manager are you using?
npm
What operating system are you using?
Linux
What browser are you using?
Firefox
Describe the Bug
Had a fully functional blog which uses .md files, but after installing markdoc and creating the config file, right when I rename a .md file to .mdoc throws this error:
What's the expected result?
It should keep working
Link to Minimal Reproducible Example
Link to my project repo: https://github.com/suhaylmv/minov-studio . Check the branch "test"
Participation
The text was updated successfully, but these errors were encountered: