fix a deprecated method in react integration using SSR: renderToStati…

…cNodeStream (#10893) * deprecated method renderToStaticNodeStream * Create twelve-bulldogs-raise.md --------- Co-authored-by: Bjorn Lu <[email protected]>
withastro · Apr 30, 2024 · fd7a9ed · fd7a9ed
1 parent 36bb3b6
commit fd7a9ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 33 deletions.
diff --git a/.changeset/twelve-bulldogs-raise.md b/.changeset/twelve-bulldogs-raise.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/react": patch
+---
+
+Removes using deprecated `ReactDOMServer.renderToStaticNodeStream` API
diff --git a/packages/integrations/react/server.js b/packages/integrations/react/server.js
@@ -106,18 +106,10 @@ async function renderToStaticMarkup(Component, props, { default: children, ...sl
 		identifierPrefix: prefix,
 	};
 	let html;
-	if (metadata?.hydrate) {
-		if ('renderToReadableStream' in ReactDOM) {
-			html = await renderToReadableStreamAsync(vnode, renderOptions);
-		} else {
-			html = await renderToPipeableStreamAsync(vnode, renderOptions);
-		}
+	if ('renderToReadableStream' in ReactDOM) {
+		html = await renderToReadableStreamAsync(vnode, renderOptions);
 	} else {
-		if ('renderToReadableStream' in ReactDOM) {
-			html = await renderToReadableStreamAsync(vnode, renderOptions);
-		} else {
-			html = await renderToStaticNodeStreamAsync(vnode, renderOptions);
-		}
+		html = await renderToPipeableStreamAsync(vnode, renderOptions);
 	}
 	return { html, attrs };
 }
@@ -150,28 +142,6 @@ async function renderToPipeableStreamAsync(vnode, options) {
 	});
 }
 
-async function renderToStaticNodeStreamAsync(vnode, options) {
-	const Writable = await getNodeWritable();
-	let html = '';
-	return new Promise((resolve, reject) => {
-		let stream = ReactDOM.renderToStaticNodeStream(vnode, options);
-		stream.on('error', (err) => {
-			reject(err);
-		});
-		stream.pipe(
-			new Writable({
-				write(chunk, _encoding, callback) {
-					html += chunk.toString('utf-8');
-					callback();
-				},
-				destroy() {
-					resolve(html);
-				},
-			})
-		);
-	});
-}
-
 /**
  * Use a while loop instead of "for await" due to cloudflare and Vercel Edge issues
  * See https://github.com/facebook/react/issues/24169