fix: attribute serialization

withastro · Nov 10, 2021 · d6ff0a7 · d6ff0a7
1 parent def7bc2
commit d6ff0a7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/astro/src/runtime/server/index.ts b/packages/astro/src/runtime/server/index.ts
@@ -208,6 +208,8 @@ export function createAstro(fileURLStr: string, site: string): TopLevelAstro {
   };
 }
 
+const toAttributeString = (value: any) => String(value).replace(/&/g, '&#38;').replace(/"/g, '&#34;')
+
 // A helper used to turn expressions into attribute key/value
 export function addAttribute(value: any, key: string) {
   if (value == null || value === false) {
@@ -216,10 +218,10 @@ export function addAttribute(value: any, key: string) {
 
   // support "class" from an expression passed into an element (#782)
   if (key === 'class:list') {
-    return ` ${key.slice(0, -5)}="${serializeListValue(value)}"`;
+    return ` ${key.slice(0, -5)}="${toAttributeString(serializeListValue(value))}"`;
   }
 
-  return ` ${key}="${value}"`;
+  return ` ${key}="${toAttributeString(value)}"`;
 }
 
 // Adds support for `<Component {...value} />