fix(node): Safely create requests (#10285)

* fix(node): Wrap request creation in try catch * chore: changeset
withastro · Mar 1, 2024 · d5277df · d5277df
1 parent afd41cc
commit d5277df
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/perfect-poets-teach.md b/.changeset/perfect-poets-teach.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/node": patch
+---
+
+Fixes an issue where malformed requests could cause the server to error in certain cases.
diff --git a/packages/integrations/node/src/serve-app.ts b/packages/integrations/node/src/serve-app.ts
@@ -8,7 +8,15 @@ import type { RequestHandler } from './types.js';
  */
 export function createAppHandler(app: NodeApp): RequestHandler {
 	return async (req, res, next, locals) => {
-		const request = NodeApp.createRequest(req);
+		let request;
+		try {
+			request = NodeApp.createRequest(req);
+		} catch (err) {
+			res.statusCode = 500;
+			res.end('Internal Server Error');
+			return;
+		}
+
 		const routeData = app.match(request);
 		if (routeData) {
 			const response = await app.render(request, {