Fix behaviour regression in create-astro (#8634)

withastro · Sep 22, 2023 · b64dd45 · b64dd45
1 parent bd00ad7
commit b64dd45
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/.changeset/neat-islands-wink.md b/.changeset/neat-islands-wink.md
@@ -0,0 +1,5 @@
+---
+'create-astro': patch
+---
+
+Fix `--yes` behaviour to prevent it overriding `--template`
diff --git a/packages/create-astro/src/actions/template.ts b/packages/create-astro/src/actions/template.ts
@@ -9,10 +9,11 @@ import { error, info, spinner, title } from '../messages.js';
 export async function template(
 	ctx: Pick<Context, 'template' | 'prompt' | 'yes' | 'dryRun' | 'exit'>
 ) {
-	if (ctx.yes) {
-		ctx.template = 'basics';
-		await info('tmpl', `Using ${color.reset(ctx.template)}${color.dim(' as project template')}`);
-	} else if (!ctx.template) {
+  if (!ctx.template && ctx.yes) ctx.template = 'basics';
+
+  if (ctx.template) {
+    await info('tmpl', `Using ${color.reset(ctx.template)}${color.dim(' as project template')}`);
+  } else {
 		const { template: tmpl } = await ctx.prompt({
 			name: 'template',
 			type: 'select',
@@ -26,8 +27,6 @@ export async function template(
 			],
 		});
 		ctx.template = tmpl;
-	} else {
-		await info('tmpl', `Using ${color.reset(ctx.template)}${color.dim(' as project template')}`);
 	}
 
 	if (ctx.dryRun) {

diff --git a/packages/create-astro/test/template.test.js b/packages/create-astro/test/template.test.js
@@ -33,4 +33,11 @@ describe('template', () => {
 
 		expect(fixture.hasMessage('Using blog as project template')).to.be.true;
 	});
+
+  it('minimal (--yes)', async () => {
+    const context = { template: 'minimal', cwd: '', dryRun: true, yes: true, prompt: () => {} };
+    await template(context);
+
+    expect(fixture.hasMessage('Using minimal as project template')).to.be.true;
+  })
 });