Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sarah Rainsberger <[email protected]>
  • Loading branch information
ematipico and sarah11918 authored Aug 19, 2024
1 parent a4fe7e1 commit a4710f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .changeset/long-months-burn.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'astro': patch
---

Changes the phrasing of the adapter features because they were misleading.
Changes messages logged when using unsupported, deprecated or experimental adapter features for clarity
6 changes: 3 additions & 3 deletions packages/astro/src/integrations/features-validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,20 +124,20 @@ function validateSupportKind(
}

function featureIsUnsupported(adapterName: string, logger: Logger, featureName: string) {
logger.error('config', `The adapter ${adapterName} doesn't support the feature "${featureName}" yet.`);
logger.error('config', `The adapter ${adapterName} doesn't currently support the feature "${featureName}".`);
}

function featureIsExperimental(adapterName: string, logger: Logger, featureName: string) {
logger.warn(
'config',
`The adapter ${adapterName} set experimental support for "${featureName}", which means that things might not work, or could change.`,
`The adapter ${adapterName} provides experimental support for "${featureName}". You may experience issues or breaking changes until this feature is fully supported by the adapter.`,
);
}

function featureIsDeprecated(adapterName: string, logger: Logger, featureName: string) {
logger.warn(
'config',
`The adapter ${adapterName} has deprecated its support for "${featureName}", which means that the feature might not work anymore in the future for this adapter.`,
`The adapter ${adapterName} has deprecated its support for "${featureName}", and future compatibility is not guaranteed. The adapter may completely remove support for this feature without warning.`,
);
}

Expand Down

0 comments on commit a4710f7

Please sign in to comment.