fix(ssg): consider trailingSlash for url (#9878)

* fix(ssg): consider trailingSlash for url * add changeset
withastro · Jan 30, 2024 · a40a0ff · a40a0ff
1 parent e9027f1
commit a40a0ff
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/wet-rivers-do.md b/.changeset/wet-rivers-do.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes an issue where setting trailingSlash to "never" had no effect on `Astro.url`.
diff --git a/packages/astro/src/core/build/generate.ts b/packages/astro/src/core/build/generate.ts
@@ -5,6 +5,7 @@ import { fileURLToPath } from 'node:url';
 import PQueue from 'p-queue';
 import type { OutputAsset, OutputChunk } from 'rollup';
 import type {
+	AstroConfig,
 	AstroSettings,
 	ComponentInstance,
 	GetStaticPathsItem,
@@ -455,15 +456,16 @@ function getUrlForPath(
 	pathname: string,
 	base: string,
 	origin: string,
-	format: 'directory' | 'file',
+	format: AstroConfig["build"]["format"],
+	trailingSlash: AstroConfig["trailingSlash"],
 	routeType: RouteType
 ): URL {
 	/**
 	 * Examples:
 	 * pathname: /, /foo
 	 * base: /
 	 */
-	const ending = format === 'directory' ? '/' : '.html';
+	const ending = format === 'directory' ? trailingSlash === 'never' ? '' : '/' : '.html';
 	let buildPathname: string;
 	if (pathname === '/' || pathname === '') {
 		buildPathname = base;
@@ -538,6 +540,7 @@ async function generatePath(
 		pipeline.getConfig().base,
 		pipeline.getStaticBuildOptions().origin,
 		pipeline.getConfig().build.format,
+		pipeline.getConfig().trailingSlash,
 		route.type
 	);
 

diff --git a/packages/astro/test/astro-get-static-paths.test.js b/packages/astro/test/astro-get-static-paths.test.js
@@ -10,6 +10,7 @@ describe('getStaticPaths - build calls', () => {
 		fixture = await loadFixture({
 			root: './fixtures/astro-get-static-paths/',
 			site: 'https://mysite.dev/',
+			trailingSlash: 'never',
 			base: '/blog',
 		});
 		await fixture.build();
@@ -29,7 +30,7 @@ describe('getStaticPaths - build calls', () => {
 		const html = await fixture.readFile('/food/tacos/index.html');
 		const $ = cheerio.load(html);
 
-		expect($('#url').text()).to.equal('/blog/food/tacos/');
+		expect($('#url').text()).to.equal('/blog/food/tacos');
 	});
 });