apply suggestion

withastro · Dec 4, 2024 · 7c0a1b4 · 7c0a1b4
1 parent d7e749f
commit 7c0a1b4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/packages/astro/src/assets/utils/svg.ts b/packages/astro/src/assets/utils/svg.ts
@@ -22,7 +22,7 @@ export type SvgRenderMode = 'inline' | 'sprite';
 export function makeSvgComponent(
 	meta: ImageMetadata,
 	contents: Buffer | string,
-	options?: { mode: SvgRenderMode },
+	options?: { mode?: SvgRenderMode },
 ) {
 	const file = typeof contents === 'string' ? contents : contents.toString('utf-8');
 	const { attributes, body: children } = parseSvg(file);

diff --git a/packages/astro/src/core/config/schema.ts b/packages/astro/src/core/config/schema.ts
@@ -539,9 +539,11 @@ export const AstroConfigSchema = z.object({
 			svg: z
 				.union([
 					z.boolean(),
-					z.object({
-						mode: z.union([z.literal('inline'), z.literal('sprite')]),
-					}),
+					z
+						.object({
+							mode: z.union([z.literal('inline'), z.literal('sprite')]).optional(),
+						})
+						.optional(),
 				])
 				.optional()
 				.default(ASTRO_CONFIG_DEFAULTS.experimental.svg)
@@ -553,6 +555,12 @@ export const AstroConfigSchema = z.object({
 									mode: 'inline' as SvgRenderMode,
 								}
 							: undefined;
+					} else {
+						if (!svgConfig.mode) {
+							return {
+								mode: 'inline' as SvgRenderMode,
+							};
+						}
 					}
 					return svgConfig;
 				}),

diff --git a/packages/astro/test/fixtures/core-image-svg/astro.config.mjs b/packages/astro/test/fixtures/core-image-svg/astro.config.mjs
@@ -4,6 +4,6 @@ import { defineConfig } from 'astro/config';
 export default defineConfig({
   integrations: [mdx()],
 	experimental: {
-		svg: true
+		svg: {}
 	}
 });