fix(deno): safely set external specifiers

withastro · Sep 23, 2023 · 75aa446 · 75aa446
1 parent 4c4ad9d
commit 75aa446
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/spotty-dryers-exist.md b/.changeset/spotty-dryers-exist.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/deno': patch
+---
+
+Fixed an issue where deno integration broke some frameworks.
diff --git a/packages/integrations/deno/src/index.ts b/packages/integrations/deno/src/index.ts
@@ -130,6 +130,12 @@ export default function createIntegration(args?: Options): AstroIntegration {
 						`[@astrojs/deno] Otherwise, this adapter is not required to deploy a static site to Deno.`
 					);
 				}
+
+			},
+			'astro:config:setup' ({ updateConfig }) {
+				updateConfig({
+					vite: { ssr: { noExternal: COMPATIBLE_NODE_MODULES } }
+				})
 			},
 			'astro:build:setup': ({ vite, target }) => {
 				if (target === 'server') {
@@ -149,9 +155,6 @@ export default function createIntegration(args?: Options): AstroIntegration {
 							(vite.resolve.alias as Record<string, string>)[alias.find] = alias.replacement;
 						}
 					}
-					vite.ssr = {
-						noExternal: COMPATIBLE_NODE_MODULES,
-					};
 
 					if (Array.isArray(vite.build.rollupOptions.external)) {
 						vite.build.rollupOptions.external.push(DENO_IMPORTS_SHIM);