chore(pr): implement changes requested in pr

withastro · May 16, 2024 · 70c45d1 · 70c45d1
1 parent ca888f0
commit 70c45d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/sweet-needles-juggle.md b/.changeset/sweet-needles-juggle.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/vue": minor
+---
+
+expose VueDevToolsOptions to allow non-default launchEditor
diff --git a/packages/integrations/vue/src/index.ts b/packages/integrations/vue/src/index.ts
@@ -13,7 +13,7 @@ const RESOLVED_VIRTUAL_MODULE_ID = `\0${VIRTUAL_MODULE_ID}`;
 interface Options extends VueOptions {
 	jsx?: boolean | VueJsxOptions;
 	appEntrypoint?: string;
-	devtools?: boolean  | {launchEditor: VitePluginVueDevToolsOptions['launchEditor'];};
+	devtools?: boolean | Omit<VitePluginVueDevToolsOptions, "appendTo">;
 }
 
 function getRenderer(): AstroRenderer {
@@ -126,11 +126,11 @@ async function getViteConfiguration(
 
 	if (command === 'dev' && options?.devtools) {
 		const vueDevTools = (await import('vite-plugin-vue-devtools')).default;
-		const launchEditor =  typeof options.devtools === 'object' ? options.devtools.launchEditor : "code"
+		const pluginOptions =  typeof options.devtools === 'object' ? options.devtools : {}
 		config.plugins?.push(
 			vueDevTools({
-				appendTo: VIRTUAL_MODULE_ID,
-				launchEditor
+				...pluginOptions,
+				appendTo: VIRTUAL_MODULE_ID
 			})
 		);
 	}