respond to final code review feedback

withastro · Mar 18, 2022 · 659ad8d · 659ad8d
1 parent 4ffc259
commit 659ad8d
Show file tree

Hide file tree

Showing 13 changed files with 29 additions and 31 deletions.
diff --git a/examples/env-vars/astro.config.mjs b/examples/env-vars/astro.config.mjs
@@ -1,6 +1,4 @@
 import { defineConfig } from 'astro/config';
 
 // https://astro.build/config
-export default defineConfig({
-	integrations: [],
-});
+export default defineConfig({});
diff --git a/examples/framework-alpine/astro.config.mjs b/examples/framework-alpine/astro.config.mjs
@@ -2,6 +2,6 @@ import { defineConfig } from 'astro/config';
 
 // https://astro.build/config
 export default defineConfig({
-	// No renderers are needed for AlpineJS support, just use Astro components!
+	// No integrations are needed for AlpineJS support, just use Astro components!
 	integrations: [],
 });
diff --git a/examples/framework-lit/astro.config.mjs b/examples/framework-lit/astro.config.mjs
@@ -3,6 +3,6 @@ import lit from '@astrojs/lit';
 
 // https://astro.build/config
 export default defineConfig({
-	// Enable the lit renderer to support LitHTML components and templates.
+	// Enable Lit to support LitHTML components and templates.
 	integrations: [lit()],
 });
diff --git a/examples/integrations-playground/README.md b/examples/integrations-playground/README.md
@@ -1,9 +1,7 @@
-# Astro + Lit Example
+# Integration Playground
 
 ```
-npm init astro -- --template framework-lit
+npm init astro -- --template integration-playground
 ```
 
-[![Open in StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/withastro/astro/tree/latest/examples/framework-lit)
-
-This example showcases Astro working with [Lit](https://lit.dev/).
+[![Open in StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/withastro/astro/tree/latest/examples/integration-playground)
diff --git a/...ions-playground/src/components/Button.jsx → ...ations-playground/src/components/Link.jsx b/...ions-playground/src/components/Button.jsx → ...ations-playground/src/components/Link.jsx
diff --git a/examples/integrations-playground/src/pages/foo.astro b/examples/integrations-playground/src/pages/foo.astro
@@ -1,6 +1,6 @@
 ---
 // Page 2!
-import Button from '../components/Button.jsx';
+import Link from '../components/Link.jsx';
 ---
 
 <!DOCTYPE html>
@@ -10,6 +10,6 @@ import Button from '../components/Button.jsx';
 		<title>Demo: Page 2</title>
 	</head>
 	<body>
-        <Button to="/" text="Go Home" />
+        <Link to="/" text="Go Home" />
 	</body>
 </html>
diff --git a/examples/integrations-playground/src/pages/index.astro b/examples/integrations-playground/src/pages/index.astro
@@ -1,6 +1,6 @@
 ---
 import Lorem from '../components/Lorem.astro';
-import Button from '../components/Button.jsx';
+import Link from '../components/Link.jsx';
 import '../components/Test.js';
 import '../components/Counter.js'; 
 ---
@@ -13,25 +13,36 @@ import '../components/Counter.js';
 	</head>
 	<body>
 		<h1 class="px-4 py-4">Test app</h1>
-		<h2 >Test app</h2>
+		<h2 class="partytown-status">
+      <strong>Party Mode!</strong> 
+      Colors changing = partytown is enabled
+    </h2>
 		<my-counter client:load></my-counter>
-    <Button to="/foo" text="Go to Page 2" />
+    <Link to="/foo" text="Go to Page 2" />
 		<Lorem />
 		<calc-add num={33}></calc-add>
 
 
     <script type="text/partytown">
-      console.log('start to block')
-      console.log(`Nah. you won't be blocked`)
+      // Remove `type="text/partytown"` to see this block the page
+      // and cause the page to become unresponsive
+      console.log('start partytown blocking script')
       const now = Date.now() 
       let count = 1;
       while (Date.now() - now < 10000) {
         if (Date.now() - now > count * 1000) {
-          console.log('blocking');
+          console.log('blocking', count);
           count += 1;
         }
       }
-      console.log('end block')
+      console.log('end partytown blocking script')
+    </script>
+
+    <script>
+      setInterval(() => {
+        const randomColor = Math.floor(Math.random()*16777215).toString(16);
+        document.querySelector('.partytown-status').style.color = "#" + randomColor;
+      }, 100);
     </script>
     <style>
 h1, h2 {

diff --git a/examples/non-html-pages/astro.config.mjs b/examples/non-html-pages/astro.config.mjs
@@ -1,7 +1,4 @@
 import { defineConfig } from 'astro/config';
 
 // https://astro.build/config
-export default defineConfig({
-	// Comment out "integrations: []" to enable Astro's default component support.
-	integrations: [],
-});
+export default defineConfig({});
diff --git a/examples/starter/astro.config.mjs b/examples/starter/astro.config.mjs
@@ -1,7 +1,4 @@
 import { defineConfig } from 'astro/config';
 
 // https://astro.build/config
-export default defineConfig({
-	// Set "integrations" to "[]" to disable all default, builtin component support.
-	integrations: [],
-});
+export default defineConfig({});
diff --git a/examples/with-markdown-plugins/astro.config.mjs b/examples/with-markdown-plugins/astro.config.mjs
@@ -4,7 +4,6 @@ import addClasses from './add-classes.mjs';
 
 // https://astro.build/config
 export default defineConfig({
-	integrations: [],
 	// Enable Custom Markdown options, plugins, etc.
 	markdownOptions: {
 		render: [

diff --git a/examples/with-markdown-shiki/astro.config.mjs b/examples/with-markdown-shiki/astro.config.mjs
@@ -3,7 +3,6 @@ import astroRemark from '@astrojs/markdown-remark';
 
 // https://astro.build/config
 export default defineConfig({
-	integrations: [],
 	// Enable Custom Markdown options, plugins, etc.
 	markdownOptions: {
 		render: [

diff --git a/examples/with-vite-plugin-pwa/astro.config.mjs b/examples/with-vite-plugin-pwa/astro.config.mjs
@@ -3,7 +3,6 @@ import { VitePWA } from 'vite-plugin-pwa';
 
 // https://astro.build/config
 export default defineConfig({
-	integrations: [],
 	vite: {
 		plugins: [VitePWA()],
 	},

diff --git a/packages/astro/src/core/config.ts b/packages/astro/src/core/config.ts
@@ -140,7 +140,7 @@ export async function validateConfig(userConfig: any, root: string): Promise<Ast
 	const fileProtocolRoot = pathToFileURL(root + path.sep);
 	// Manual deprecation checks
 	/* eslint-disable no-console */
-	if (userConfig.renderers) {
+	if (userConfig.hasOwnProperty('renderers')) {
 		console.error('Astro "renderers" are now "integrations"!');
 		console.error('Update your configuration and install new dependencies:');
 		try {