Use AstroCookieSetOptions to construct AstroCookieDeleteOptions

withastro · Apr 8, 2024 · 58e6fed · 58e6fed
1 parent 6035992
commit 58e6fed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/shaggy-cats-film.md b/.changeset/shaggy-cats-film.md
@@ -1,5 +1,11 @@
 ---
-"astro": patch
+"astro": minor
 ---
 
-Accept standard cookie attributes when deleting a cookie
+Extends the acceptable cookie options when deleting a cookie, to the following attribute:
+
+- `domain`
+- `path`
+- `httpOnly` *(Added)*
+- `sameSite` *(Added)*
+- `secure` *(Added)*
diff --git a/packages/astro/src/core/cookies/cookies.ts b/packages/astro/src/core/cookies/cookies.ts
@@ -11,7 +11,7 @@ export interface AstroCookieGetOptions {
 	decode?: (value: string) => string;
 }
 
-type AstroCookieDeleteOptions = Omit<CookieSerializeOptions, 'expires' | 'maxAge'>;
+type AstroCookieDeleteOptions = Omit<AstroCookieSetOptions, 'expires' | 'maxAge' | 'encode'>;
 
 interface AstroCookieInterface {
 	value: string;