Update based on review comments

packages/integrations/preact/src/index.ts

@@ -13,7 +13,7 @@ function getRenderer(development: boolean): AstroRenderer {
 }
 
 export type Options =Pick<VitePreactPluginOptions, 'include' | 'exclude'> & { compat?: boolean };
-// TODO: Add back compat support -- how would this work in the new world?
+
 export default function ({include, exclude, compat}: Options = {}): AstroIntegration {
 	return {
 		name: '@astrojs/preact',
@@ -53,7 +53,7 @@ export default function ({include, exclude, compat}: Options = {}): AstroIntegra
 						dedupe: ['preact/compat', 'preact'],
 					};
 					// noExternal React entrypoints to be bundled, resolved, and aliased by Vite
-					viteConfig.ssr = {
+					viteConfig.ssr = {f
 						noExternal: ['react', 'react-dom', 'react-dom/test-utils', 'react/jsx-runtime'],
 					};
 				}

packages/integrations/react/package.json

@@ -44,6 +44,7 @@
     "dev": "astro-scripts dev \"src/**/*.ts\""
   },
   "dependencies": {
+    "@astrojs/internal-helpers": "0.2.0-beta.0",
     "@vitejs/plugin-react": "^4.0.3"
   },
   "devDependencies": {

packages/integrations/react/src/index.ts

@@ -1,6 +1,7 @@
 import type { AstroIntegration } from 'astro';
 import { version as ReactVersion } from 'react-dom';
 import react, {type Options as ViteReactPluginOptions} from '@vitejs/plugin-react';
+import { appendForwardSlash } from '@astrojs/internal-helpers/path';
 
 
 const FAST_REFRESH_PREAMBLE = react.preambleCode;
@@ -64,7 +65,7 @@ export default function ({include, exclude}: Pick<ViteReactPluginOptions, 'inclu
 				addRenderer(getRenderer());
 				updateConfig({ vite: getViteConfiguration({include, exclude}) });
 				if (command === 'dev') {
-					const preamble = FAST_REFRESH_PREAMBLE.replace(`__BASE__`, config.base)
+					const preamble = FAST_REFRESH_PREAMBLE.replace(`__BASE__`, appendForwardSlash(config.base))
 					injectScript('before-hydration', preamble);
 				}
 			},

packages/integrations/solid/src/index.ts

@@ -1,19 +1,14 @@
-import type { AstroConfig, AstroIntegration, AstroRenderer } from 'astro';
+import type { AstroIntegration, AstroRenderer } from 'astro';
 import solid, { type Options as ViteSolidPluginOptions } from 'vite-plugin-solid';
 
 async function getViteConfiguration(
 	isDev: boolean,
-	astroConfig: AstroConfig,
 	{ include, exclude }: Options = {},
 ) {
 	// https://github.com/solidjs/vite-plugin-solid
 	// We inject the dev mode only if the user explicitly wants it or if we are in dev (serve) mode
 	const nestedDeps = ['solid-js', 'solid-js/web', 'solid-js/store', 'solid-js/html', 'solid-js/h'];
 	return {
-		/**
-		 * We only need esbuild on .ts or .js files.
-		 * .tsx & .jsx files are handled by us
-		 */
 		resolve: {
 			conditions: ['solid', ...(isDev ? ['development'] : [])],
 			dedupe: nestedDeps,
@@ -59,13 +54,10 @@ export default function (opts: Options = {}): AstroIntegration {
 	return {
 		name: '@astrojs/solid-js',
 		hooks: {
-			'astro:config:setup': async ({ command, addRenderer, updateConfig, config }) => {
+			'astro:config:setup': async ({ command, addRenderer, updateConfig }) => {
 				addRenderer(getRenderer());
 				updateConfig({
-					/*vite: {
-						plugins: [solid({ include, exclude, dev: command === 'dev', ssr: true })]
-					}*/
-					vite: await getViteConfiguration(command === 'dev', config, opts),
+					vite: await getViteConfiguration(command === 'dev', opts),
 				});
 			},
 		},