chore: remove drop table check for added table (#10396)

* chore: remove drop table check for added table * chore: remove drop table from test * chore: changeset
withastro · Mar 12, 2024 · 41ca94e · 41ca94e
1 parent 629c9d7
commit 41ca94e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.changeset/lazy-tools-reply.md b/.changeset/lazy-tools-reply.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/db": patch
+---
+
+Remove risk of data loss when pushing an out-of-date table schema.
diff --git a/packages/db/src/core/cli/migration-queries.ts b/packages/db/src/core/cli/migration-queries.ts
@@ -61,7 +61,6 @@ export async function getMigrationQueries({
 	}
 
 	for (const [collectionName, collection] of Object.entries(addedCollections)) {
-		queries.push(getDropTableIfExistsQuery(collectionName));
 		queries.push(getCreateTableQuery(collectionName, collection));
 		queries.push(...getCreateIndexQueries(collectionName, collection));
 	}

diff --git a/packages/db/test/unit/column-queries.test.js b/packages/db/test/unit/column-queries.test.js
@@ -53,7 +53,6 @@ describe('column queries', () => {
 			const newCollections = { [TABLE_NAME]: userInitial };
 			const { queries } = await configChangeQueries(oldCollections, newCollections);
 			expect(queries).to.deep.equal([
-				`DROP TABLE IF EXISTS "${TABLE_NAME}"`,
 				`CREATE TABLE "${TABLE_NAME}" (_id INTEGER PRIMARY KEY, "name" text NOT NULL, "age" integer NOT NULL, "email" text NOT NULL UNIQUE, "mi" text)`,
 			]);
 		});