Do not crawl non-style deps imported by styles (#4115)

* fix: do not crawl non-style deps imported by styles * Update vite.ts Co-authored-by: Nate Moore <[email protected]>
withastro · Aug 2, 2022 · 26cc0bb · 26cc0bb
1 parent 004995e
commit 26cc0bb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.changeset/weak-crabs-pump.md b/.changeset/weak-crabs-pump.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix edge case with hoisted scripts and Tailwind during dev
diff --git a/packages/astro/src/core/render/dev/vite.ts b/packages/astro/src/core/render/dev/vite.ts
@@ -1,5 +1,6 @@
 import npath from 'path';
 import vite from 'vite';
+import { STYLE_EXTENSIONS } from '../util.js';
 import { unwrapId } from '../../util.js';
 
 /**
@@ -36,13 +37,21 @@ export async function* crawlGraph(
 		}
 		if (id === entry.id) {
 			scanned.add(id);
+			const entryIsStyle = STYLE_EXTENSIONS.has(npath.extname(id))
 			for (const importedModule of entry.importedModules) {
 				// some dynamically imported modules are *not* server rendered in time
 				// to only SSR modules that we can safely transform, we check against
 				// a list of file extensions based on our built-in vite plugins
 				if (importedModule.id) {
 					// use URL to strip special query params like "?content"
 					const { pathname } = new URL(`file://${importedModule.id}`);
+					// If the entry is a style, skip any modules that are not also styles.
+					// Tools like Tailwind might add HMR dependencies as `importedModules`
+					// but we should skip them--they aren't really imported. Without this,
+					// every hoisted script in the project is added to every page!
+					if (entryIsStyle && !STYLE_EXTENSIONS.has(npath.extname(pathname))) {
+						continue;
+					}
 					if (fileExtensionsToSSR.has(npath.extname(pathname))) {
 						const mod = viteServer.moduleGraph.getModuleById(importedModule.id);
 						if (!mod?.ssrModule) {