fix: do not append traling slash to subresource urls

Signed-off-by: Andres Correa Casablanca <[email protected]>

.changeset/tender-snails-accept.md

@@ -0,0 +1,5 @@
+---
+"@astrojs/node": patch
+---
+
+fix: do not append traling slash to subresource urls

packages/integrations/node/src/serve-static.ts

@@ -48,7 +48,8 @@ export function createStaticHandler(app: NodeApp, options: Options) {
 					}
 					break;
 				case 'always':
-					if (!hasSlash) {
+					// trailing slash is not added to "subresources"
+					if (!hasSlash && !urlPath.match(/.+\.[a-z]+$/i)) {
 						pathname = urlPath + '/' + (urlQuery ? '?' + urlQuery : '');
 						res.statusCode = 301;
 						res.setHeader('Location', pathname);

packages/integrations/node/test/fixtures/trailing-slash/public/one.css

@@ -0,0 +1 @@
+h1 { color: red; }

packages/integrations/node/test/trailing-slash.js → packages/integrations/node/test/trailing-slash.test.js

@@ -1,4 +1,4 @@
-import { expect } from 'chai';
+import { after, before, describe, it, expect } from 'node:test';
 import * as cheerio from 'cheerio';
 import nodejs from '../dist/index.js';
 import { loadFixture } from './test-utils.js';
@@ -76,6 +76,14 @@ describe('Trailing slash', () => {
 				expect(res.status).to.equal(200);
 				expect($('h1').text()).to.equal('One');
 			});
+
+			it('Does not add trailing slash to subresource urls', async () => {
+				const res = await fetch(`http://${server.host}:${server.port}/some-base/one.css`);
+				const css = await res.text();
+
+				expect(res.status).to.equal(200);
+				expect(css).to.equal('h1 { color: red; }\n');
+			})
 		});
 		describe('Without base', async () => {
 			before(async () => {
@@ -133,6 +141,14 @@ describe('Trailing slash', () => {
 				expect(res.status).to.equal(200);
 				expect($('h1').text()).to.equal('One');
 			});
+
+			it('Does not add trailing slash to subresource urls', async () => {
+				const res = await fetch(`http://${server.host}:${server.port}/one.css`);
+				const css = await res.text();
+
+				expect(res.status).to.equal(200);
+				expect(css).to.equal('h1 { color: red; }\n');
+			})
 		});
 	});
 	describe('Never', async () => {