Skip to content

Commit

Permalink
Raise error for duplicate content entry slugs (#7352)
Browse files Browse the repository at this point in the history
* chore: throw error on dup slugs

* chore: move to ErrorData

* fix: remove unknownerror

* chore: changeset
  • Loading branch information
bholmesdev authored Jun 10, 2023
1 parent 777e5d7 commit 0a8d178
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/yellow-icons-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Raise error when multiple content collection entries have the same slug
10 changes: 10 additions & 0 deletions packages/astro/src/content/vite-plugin-content-virtual-mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,16 @@ export async function getStringifiedLookupMap({
fileUrl: pathToFileURL(filePath),
contentEntryType,
});
if (lookupMap[collection]?.entries?.[slug]) {
throw new AstroError({
...AstroErrorData.DuplicateContentEntrySlugError,
message: AstroErrorData.DuplicateContentEntrySlugError.message(collection, slug),
hint:
slug !== generatedSlug
? `Check the \`slug\` frontmatter property in **${id}**.`
: undefined,
});
}
lookupMap[collection] = {
type: 'content',
entries: {
Expand Down
12 changes: 12 additions & 0 deletions packages/astro/src/core/errors/errors-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,18 @@ See https://docs.astro.build/en/guides/server-side-rendering/ for more informati
},
hint: 'Ensure your data entry is an object with valid JSON (for `.json` entries) or YAML (for `.yaml` entries).',
},
/**
* @docs
* @description
* Content collection entries must have unique slugs. Duplicates are often caused by the `slug` frontmatter property.
*/
DuplicateContentEntrySlugError: {
title: 'Duplicate content entry slug.',
code: 9008,
message: (collection: string, slug: string) => {
return `**${collection}** contains multiple entries with the same slug: \`${slug}\`. Slugs must be unique.`;
},
},

/**
* @docs
Expand Down

0 comments on commit 0a8d178

Please sign in to comment.