Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflows to match changes from #74 #76

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 21, 2024

Realised I forgot to update the Node and PNPM versions used by the auto-format and lint GitHub workflows leading the auto-format bot to reset the lock file using PNPM v8 in c890718 for example.

This PR updates those two workflows to use the same Node version as we specify in .nvmrc and to let the PNPM setup step infer PNPM version from package.json.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for astro-new ready!

Name Link
🔨 Latest commit 6c5b5f4
🔍 Latest deploy log https://app.netlify.com/sites/astro-new/deploys/673f28e0b0ae9f0008de5a28
😎 Deploy Preview https://deploy-preview-76--astro-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not break the site for me!

@delucis delucis merged commit a3b83ee into main Nov 21, 2024
5 checks passed
@delucis delucis deleted the chris/fix-autoformat branch November 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants