Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove large blurs #1350

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Remove large blurs #1350

merged 4 commits into from
Dec 13, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 13, 2024

This PR aims to close #1274

In several places we had a very large (160px) blur on decorative background elements. These look great, but do not perform well across browsers. In #1228 I had already reduced blur on the hero image to just 16px to improve Safari performance, but didn’t notice these other large blurs at the time.

This PR

  • Replaces the two instances of 160px blur with an alternative approach using a radial-gradient mask on the element to simulate a blurred fall-off of intensity. To the trained eye, these are subtly different effects, but they are close enough and I think the trade-off is justified to address poor performance.
  • Removes several places we were using backdrop-blur unnecessarily (the backdrop was already something blurry or a flat colour so recalculating additional blurs was superfluous)
  • Removes an old component we were no longer using

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 0772951
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/675c5145a32b0d00082f4cc6
😎 Deploy Preview https://deploy-preview-1350--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
5 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 2 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only on Chrome and can't perceive a difference between the deploy preview and live docs, so certainly nothing appears to have gone wrong in this PR for me!

@delucis delucis merged commit 5c44c82 into main Dec 13, 2024
6 checks passed
@delucis delucis deleted the chris/deblur branch December 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astro.build main page performance is awful in Safari
2 participants