Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and performance fixes #1228

Merged
merged 20 commits into from
Aug 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
88b8ea8
Fix DOM structure of landing page tabs
delucis Aug 22, 2024
db52933
Fix missing accessible labels in theme image gallery
delucis Aug 22, 2024
6ac40ad
Fix heading levels in Privacy Policy and Terms of Service
delucis Aug 22, 2024
1bf00f0
Fix cards in lists that aren’t list items
delucis Aug 22, 2024
259b14d
Fix ARIA and clean up verbose JS in use case tabs
delucis Aug 22, 2024
e9292a0
Fix failing text contrast in ORM and SQL feature cards
delucis Aug 22, 2024
eed35fc
Fix misused `<aside>` in `/db/` hero section
delucis Aug 22, 2024
df564df
Fix misused `<dl>` in intro section of `/db/`
delucis Aug 22, 2024
7366250
Fix clash of names between DB subnav and footer `<nav>` elements
delucis Aug 22, 2024
64acf4d
Add trailing slashes to internal theme and showcase links to match ca…
delucis Aug 22, 2024
2e095da
Fix landing page hero performance
delucis Aug 22, 2024
c289552
Lazy load below the fold images on the homepage
delucis Aug 22, 2024
a7551cc
Prioritise hero background loading on landing page
delucis Aug 22, 2024
07ebade
More lazy load opportunities on homepage
delucis Aug 22, 2024
cf75c7c
Add cache headers for `/fonts/*` CDN
delucis Aug 22, 2024
55b3128
Reduce size of ecosystem thumbnails on homepage
delucis Aug 22, 2024
3cf26a9
Use inline SVGs for islands performance chart
delucis Aug 22, 2024
ca8e561
Revert `fonts/*` headers change — needs setting at CDN level
delucis Aug 22, 2024
1469def
Fix content shift in theme tabs component
delucis Aug 22, 2024
507045b
Merge branch 'main' into chris/a11y
delucis Aug 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix misused <aside> in /db/ hero section
  • Loading branch information
delucis committed Aug 22, 2024
commit eed35fc60c83194e512c2cab0d2526261874fbd0
6 changes: 3 additions & 3 deletions src/pages/db/_components/Pill.astro
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ type Props = {
const { title, subtitle, class: className } = Astro.props;
---

<aside
<div
class:list={[
'relative flex gap-2 rounded-full text-xs transition-colors duration-150 md:text-sm',
className,
@@ -18,10 +18,10 @@ const { title, subtitle, class: className } = Astro.props;
<span class="pill relative m-px rounded-full px-3 py-1">{title}</span>
{subtitle && <span>{subtitle}</span>}
</span>
</aside>
</div>

<style>
aside::before {
div::before {
@apply absolute inset-0 border border-white/40;
content: '';
border-radius: inherit;