This repository has been archived by the owner on Feb 10, 2025. It is now read-only.
feat: update adapters supported features to account for new shape for Astro 5 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96c75e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 52 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
commented
Sep 13, 2024
| @@ -455,12 +455,7 @@ export default function netlifyIntegration( | |||
| hybridOutput: 'stable', | |||
| staticOutput: 'stable', | |||
| serverOutput: 'stable', | |||
| assets: { | |||
| // keeping this as experimental at least until Netlify Image CDN is out of beta | |||
| supportKind: 'experimental', | |||
There was a problem hiding this comment.
It makes no sense for Netlify to use this to reflect the Image CDN service being experimental. This leads to a wonky spooky messages for users (assets are not supported, what does that mean?)
I just updated it to match the new config, but a warning could be added separately from this (using the adapter config to check if the image cdn is enabled)
florian-lefebvre
approved these changes
Sep 13, 2024
Merged
This was referenced Sep 23, 2024
This was referenced Oct 6, 2024
This was referenced Oct 24, 2024
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
… Astro 5 (#392) * feat: update adapters supported features to account for new shape for Astro 5 * chore: changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In Astro 5, the section on assets has been removed from supportedAstroFeatures because it made no sense, you cannot not support "assets" as a concept, otherwise your adapter either can't have routes (it doesn't support having an endpoint), or does not support hosting assets in general (so you don't support any imports that results in a file, no JS, no CSS, no images etc)
In truth, adapters always support
astro:assetsthe feature, what they don't support is the default image service that relies on Node API at runtime. As such, options we updated to reflect only that.Testing
N/A
Docs
N/A