Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect netlify redirect test #39

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 23, 2023

Changes

Fix incorrect assertion. Inside the try block, the assertion is intentionally failing to fail the test, however because it's still within the try block, the catch block will turn it back to passing, which is incorrect.

Testing

Ran the tests manually. Found this while working on withastro/astro#7889

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: e18e16f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ematipico ematipico merged commit 69a1a03 into main Oct 24, 2023
8 checks passed
@ematipico ematipico deleted the fix-netlify-redirect-test branch October 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants