Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

feat(cloudflare): runtime injected types #355

Closed
wants to merge 2 commits into from

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Aug 19, 2024

Todo

  • code
  • todos
  • changeset
  • docs
  • pr desc

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: d728d16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait and see if wrangler can add an API for us in time.

@florian-lefebvre
Copy link
Member Author

Can reopen later if there's still interest

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Dec 10, 2024

cc @dario-piotrowicz

This was blocked because we didn't want to ship the solution with calling wrangler types in a child_process. However if we can get an API which returns us the output of wrangler types as a string, we can reimplement this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants