Skip to content

Commit

Permalink
fix(cloudflare): Fixes peer dependency conflict (#344)
Browse files Browse the repository at this point in the history 
* Fix peer dependency conflict

* Update smooth-frogs-rush.md

---------

Co-authored-by: Alexander Niebuhr <[email protected]>
  • Loading branch information
@Fryuni @alexanderniebuhr
Fryuni and alexanderniebuhr authored Aug 4, 2024
1 parent 1831bd6 commit 8d7766e
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/smooth-frogs-rush.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': patch
---

Updates a dependency to align the peer dependency version for Astro
2 changes: 1 addition & 1 deletion packages/cloudflare/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"miniflare": "^3.20240620.0",
"tiny-glob": "^0.2.9",
"wrangler": "^3.62.0",
"@inox-tools/astro-when": "^0.2.0"
"@inox-tools/astro-when": "^0.2.1"
},
"peerDependencies": {
"astro": "^4.10.3"
Expand Down
12 changes: 6 additions & 6 deletions pnpm-lock.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 comments on commit 8d7766e

@nlnw
Copy link

@nlnw nlnw commented on 8d7766e Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the issue. #343
This plugin is currently totally broken because of the changes in .2 and .3

@alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented on 8d7766e Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlnw It doesn't help to comment this multiple times. Please provide a repository for us in your issue #343, so we can analyze the issue. We have multiple maintainers who tried this with multiple Astro projects and it doesn't break for us, so we need to see your project.

@nlnw
Copy link

@nlnw nlnw commented on 8d7766e Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should revert these changes first since I'm not the only one who reported the issue. The changes look pretty strange anyway in the last two versions.

Please sign in to comment.