-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for line breaks in certain fields #64
Conversation
Implemented in `type`, `subtype`, `notes` fields
1fca105
to
46ed241
Compare
wire_type = f', {remove_line_breaks(shared["type"])}' if 'type' in shared else '' | ||
gauge_name = f', {shared["gauge"]} {shared["gauge_unit"]}' if 'gauge' in shared else '' | ||
wire_type = f', {remove_line_breaks(shared["type"])}' if shared.get('type', None) else '' | ||
gauge_name = f', {shared["gauge"]} {shared["gauge_unit"]}' if shared.get('gauge', None) else '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new syntax catches both missing keys and keys with None
as value.
@@ -343,7 +343,7 @@ def bom(self): | |||
if bundle.category == 'bundle': | |||
# add each wire from each bundle to the wirelist | |||
for index, color in enumerate(bundle.colors, 0): | |||
wirelist.append({'gauge': bundle.gauge, 'gauge_unit': bundle.gauge_unit, 'length': bundle.length, 'color': color, 'designator': bundle.name, | |||
wirelist.append({'type': bundle.type, 'gauge': bundle.gauge, 'gauge_unit': bundle.gauge_unit, 'length': bundle.length, 'color': color, 'designator': bundle.name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were ignoring the type for bundles. In general, I see no reason to.
This looks good to me, I think you have got all the fields that make sense to add line-breaks to and i couldn't spot any places those fields are printed which doesn't go through one of the three line break functions. |
Closes #49. @Tyler-Ward perhaps you can can have a quick look and let me know if something's missing.
I am aware that ferrules are not rendered very nicely if their fields include line breaks (try my test code) so I'll tackle that next. It's a cosmetic issue not related to the actual line break support.