-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to export PNG data directly to other programs. #55
Conversation
Thanks, I like the idea a lot. I merged it and took the liberty to rewrite the addition to the parse() function (144c99e), let me know what you think. Returning the BOM as a 2D list (just like the TSV output), or as a dict, could also be a nice addition, but that's a story for another PR. |
Thanks for accepting the merge. The GUI code that uses your repo: wireviz-gui Installation is a bit complicated at the moment, but that will be simplified as the code bases become more stable. Look forward to seeing what the future brings! |
@slightlynybbled, here's a little recommendation for future commit messages, both here and in your own repos, regarding the use of imperative mood. I noticed the messages in your wireviz-gui repo might benefit from this :) |
Thank you for making me aware. I had no idea this was a thing!
…On Mon, Jul 6, 2020 at 4:42 PM Daniel Rojas ***@***.***> wrote:
@slightlynybbled <https://github.com/slightlynybbled>, here
<https://chris.beams.io/posts/git-commit/#imperative>'s a little
recommendation for future commit messages, both here and in your own repos,
regarding the use of imperative mood. I noticed the messages in your
wireviz-gui repo might benefit from this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARYN3WOOJD4GIATEMTLG6LR2IZMBANCNFSM4OPDLLYA>
.
|
Just wanted to let you know that I created a bundled executable based on your current dev branch. https://github.com/slightlynybbled/wireviz-gui https://github.com/slightlynybbled/wireviz-gui/releases Your repository is credited and linked in the Not feature-rich yet, but a better workflow for those unhappy with the command line... Thank you for this package! As it becomes more mature, I will continue to add features! |
I would like to build on your tool with a GUI. This pull request puts the beginnings of the API into the project.
Example Usage
Future Work
At this time, I only added support for
png
, but I left room in there to potentially add more types and even multiple types. Also put the beginnings of a docstring in there to explain my changes, but didn't fill it out fully just in case you wanted to put your own words in there.