Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace os.path with pathlib.Path #246

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Replace os.path with pathlib.Path #246

merged 4 commits into from
Aug 5, 2022

Conversation

formatc1702
Copy link
Collaborator

Closes #190.

@formatc1702 formatc1702 changed the base branch from master to dev October 7, 2021 21:30
@formatc1702 formatc1702 marked this pull request as ready for review October 7, 2021 21:34
@formatc1702 formatc1702 requested a review from kvid October 7, 2021 21:34
@formatc1702 formatc1702 modified the milestones: v0.3, v0.4 Oct 7, 2021
@formatc1702 formatc1702 changed the base branch from dev to feature/technical-drw October 15, 2021 13:10
@formatc1702 formatc1702 mentioned this pull request Oct 15, 2021
Open
@formatc1702 formatc1702 force-pushed the feature/technical-drw branch from 293c896 to b513051 Compare October 16, 2021 19:55
kvid
kvid requested changes Jan 9, 2022
View reviewed changes
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like the pathlib interface. Consider the change suggested by @laurierloi and a few other code alternatives.

setup.py Show resolved Hide resolved
src/wireviz/build_examples.py Show resolved Hide resolved
src/wireviz/wireviz.py Show resolved Hide resolved
src/wireviz/wireviz.py Show resolved Hide resolved
src/wireviz/wireviz.py Show resolved Hide resolved
src/wireviz/wireviz.py Show resolved Hide resolved
@formatc1702 formatc1702 mentioned this pull request Aug 5, 2022
Open
5 tasks
@formatc1702
Copy link
Collaborator Author

All comments have been addressed inside #251 or are no longer relevant after 251 is applied

@formatc1702 formatc1702 merged commit 8e59a14 into feature/technical-drw Aug 5, 2022
@formatc1702 formatc1702 deleted the feature/pathlib branch August 5, 2022 16:29
formatc1702 added a commit that referenced this pull request Aug 5, 2022
@formatc1702
Add suggestions from #246
e51634d
laurierloi pushed a commit to laurierloi/WireViz that referenced this pull request Jan 19, 2023
@formatc1702 @laurierloi
Add suggestions from wireviz#246
b075e06
formatc1702 added a commit that referenced this pull request Jun 7, 2023
@formatc1702
Add suggestions from #246
d8791dc
kvid pushed a commit to kvid/WireViz that referenced this pull request Aug 27, 2023
@formatc1702 @kvid
Add suggestions from wireviz#246
1e78b3c
kvid pushed a commit to kvid/WireViz that referenced this pull request Sep 12, 2023
@formatc1702 @kvid
Add suggestions from wireviz#246
c3b07cf
@martinrieder martinrieder mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurierloi laurierloi laurierloi left review comments

@kvid kvid kvid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

[internal] Replaceos.path with Pathlib
3 participants
@formatc1702 @kvid @laurierloi