Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/dash in pinlabel #140

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Bugfix/dash in pinlabel #140

merged 1 commit into from
Aug 10, 2020

Conversation

formatc1702
Copy link
Collaborator

Fixes #139.

@formatc1702 formatc1702 changed the base branch from master to dev July 30, 2020 16:40
@formatc1702 formatc1702 added this to the v0.2 milestone Aug 2, 2020
kvid
kvid requested changes Aug 9, 2020
View reviewed changes
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that with this fix, the test case in issue #139 produces the expected result without stopping with an error.

src/wireviz/wv_helper.py Outdated Show resolved Hide resolved
@formatc1702 formatc1702 force-pushed the bugfix/dash-in-pinlabel branch from 255377b to 73d894d Compare August 10, 2020 15:04
@formatc1702 formatc1702 merged commit 4802705 into dev Aug 10, 2020
@formatc1702 formatc1702 deleted the bugfix/dash-in-pinlabel branch August 10, 2020 15:04
@kvid kvid mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvid kvid kvid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

[bug] Referencing pin labels with '-' when defining connections
2 participants
@formatc1702 @kvid