Make each shield wire uniform and allow cable.shield color #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the spline shield wires were rendered as tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together. Each shield wire is now rendered equally along the spline sections and in cable nodes. If cable.shield is true, they are rendered as thin black wires in the same way as before multi-colors were introduced. The new feature is that cable.shield is allowed to contain a two-letter color code to specify a colored shield wire with black borders. The shield wire thickness is not increased, even if the cable has some multi-colored wires that makes all other wires to increase. This fixes bug wireviz#125.
kvid
changed the title
formatc1702
added a commit
that referenced
this pull request
Jul 27, 2020
Feature introduced in #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the spline shield wires are rendered as thin tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together, e.g. in tutorial03.png:
The shield wires in cable nodes are now rendered equally as the spline shield wires. The default behavior is now kept as before multi-colors were introduced. This is tutorial03.png produced after the fix:
The new feature is that
cable.shieldis allowed to contain a two-letter color code to specify a colored shield wire with black borders. This is tutorial03.png produced from a modified YAML file:With this new feature, it is also possible for the user to visualize copper or golden shields, and even different shields for different cables in the same diagram if needed.
The shield wire thickness is not increased, even if the cable has some multi-colored wires that makes all other wires to increase.
This fixes bug #125. I know #74 and/or #120 will probably change this, but as those draft PRs have no priority right now (in milestone v0.3 = do later), I suggest this tiny little change as a quick solution for now.