Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

length precision #340

Closed
freiadam opened this issue May 7, 2024 · 3 comments · Fixed by #374
Closed

length precision #340

freiadam opened this issue May 7, 2024 · 3 comments · Fixed by #374

Comments

@freiadam
Copy link

freiadam commented May 7, 2024

If "length: 1000 mm" in YAML the result will be 1000.0 mm in the output files. I think it should be 1000 mm. Is there a solution for this?
kvid added a commit that referenced this issue Jun 4, 2024
@kvid
Avoid decimal point and trailing zero for integer BOM quantities
0c11357 
Fixes #340
@kvid kvid mentioned this issue Jun 4, 2024
Merged
@kvid
Copy link
Collaborator

kvid commented Jun 4, 2024

@freiadam - Thank you for reporting this issue, but the next time, please read our contributing guidelines that describes all the information you should provide when reporting an issue (versions of your software & OS, YAML input, etc.)

You can now try the change in PR #374 to see if that is a solution for you, and report back here.

kvid added a commit that referenced this issue Jun 7, 2024
@kvid
Avoid decimal point and trailing zero for integer BOM quantities
db1e77f 
Fixes #340
kvid added a commit that referenced this issue Jun 7, 2024
@kvid
Avoid decimal point and trailing zero for integer BOM quantities (#374)
baa2936 
Fixes #340
kvid added a commit that referenced this issue Jun 12, 2024
@kvid
Avoid decimal point and trailing zero for integer BOM quantities (#374)
70cd3b1 
Fixes #340
@kvid kvid linked a pull request Jun 22, 2024 that will close this issue
Avoid decimal point and trailing zero for integer BOM quantities #374
Merged
@kvid
Copy link
Collaborator

kvid commented Jul 6, 2024

The relevant fixes are now merged into the release/v0.4.1-rc branch of PR #365 that is not yet released, but also describes how you can install the latest collection of fixes before the release.

@kvid
Copy link
Collaborator

kvid commented Jul 13, 2024

Closed after releasing v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid decimal point and trailing zero for integer BOM quantities wireviz/WireViz
2 participants
@kvid @freiadam