Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csvjson: Do not emit empty properties #869

Merged
merged 1 commit into from
Jul 24, 2017
Merged

csvjson: Do not emit empty properties #869

merged 1 commit into from
Jul 24, 2017

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 24, 2017

No description provided.

@jayvdb jayvdb mentioned this pull request Jul 24, 2017
Closed
@coveralls
Copy link

coveralls commented Jul 24, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 87.5% when pulling acaf5ce on jayvdb:csvjson-discard-empty-props into da1f330 on wireservice:master.

@jpmckinney jpmckinney merged commit 6b6d7c8 into wireservice:master Jul 24, 2017
@jpmckinney
Copy link
Member

Thanks!

jpmckinney pushed a commit that referenced this pull request Jul 24, 2017
Change #869 to emit properties as long as they are not null
f63a654
@jpmckinney
Copy link
Member

jpmckinney commented Jul 24, 2017 •
edited
Loading

Note, in the above commit I changed the check to c is not None, as otherwise real data values like False won't be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayvdb @coveralls @jpmckinney