ignore corrupt events on disk (users might edit it on web)

lib/src/analytics/analytics.dart

@@ -8,7 +8,6 @@ import 'package:wiredash/src/core/version.dart';
 import 'package:wiredash/src/core/wiredash_widget.dart';
 
 // Required
-// TODO ignore corrupt events on disk (users might edit it on web)
 // TODO export analytics
 // TODO Write documentation
 

lib/src/analytics/event_store.dart

@@ -64,7 +64,7 @@ class PersistentAnalyticsEventStore implements AnalyticsEventStore {
     await prefs.reload();
     final keys = prefs.getKeys();
 
-    final Map<String, AnalyticsEvent> toBeSubmitted = {};
+    final Map<String, AnalyticsEvent> result = {};
     for (final key in keys) {
       final match = eventKeyRegex.firstMatch(key);
       if (match == null) continue;
@@ -75,7 +75,7 @@ class PersistentAnalyticsEventStore implements AnalyticsEventStore {
         try {
           final AnalyticsEvent event =
               deserializeEventV1(jsonDecode(eventJson) as Map<String, Object?>);
-          toBeSubmitted[key] = event;
+          result[key] = event;
         } catch (e, stack) {
           reportWiredashInfo(
             e,
@@ -86,7 +86,7 @@ class PersistentAnalyticsEventStore implements AnalyticsEventStore {
         }
       }
     }
-    return toBeSubmitted;
+    return result;
   }
 
   @override

test/analytics/event_store_test.dart

@@ -0,0 +1,36 @@
+import 'package:flutter_test/flutter_test.dart';
+import 'package:shared_preferences/shared_preferences.dart';
+import 'package:wiredash/src/analytics/event_store.dart';
+
+import '../util/flutter_error.dart';
+
+void main() {
+  test('ignore invalid events on disk', () async {
+    SharedPreferences.setMockInitialValues({});
+    final errors = captureFlutterErrors();
+    final eventStore = PersistentAnalyticsEventStore(
+      sharedPreferences: SharedPreferences.getInstance,
+    );
+
+    final prefs = await SharedPreferences.getInstance();
+    await prefs.setString(
+        'io.wiredash.events.default|1234567890|abc', '{"invalid": "event"}');
+    final events = await eventStore.getEvents(null);
+
+    errors.restoreDefaultErrorHandlers();
+
+    expect(events, hasLength(0));
+    // reported warning
+    expect(
+      errors.presentErrorText,
+      contains(
+        'Error when parsing event io.wiredash.events.default|1234567890|abc. Removing',
+      ),
+    );
+    expect(
+      prefs.getString('io.wiredash.events.default|1234567890|abc'),
+      isNull,
+      reason: 'Invalid event should be removed from disk',
+    );
+  });
+}