feat: Show members found on backend in start UI #8510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffflorian
suggested changes
Apr 7, 2020
| @@ -335,25 +336,14 @@ class StartUIViewModel { | |||
| this.services.removeAll(); | |||
| } | |||
|
|
|||
| _searchPeople(query) { | |||
| async _searchPeople(query) { | |||
There was a problem hiding this comment.
There is an await now in line 373.
ffflorian
approved these changes
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## edge #8510 +/- ##
=======================================
Coverage 53.21% 53.22%
=======================================
Files 384 384
Lines 13465 13464 -1
Branches 1690 1690
=======================================
Hits 7166 7166
+ Misses 5779 5778 -1
Partials 520 520 |
AndyLnd
pushed a commit
that referenced
this pull request
Apr 23, 2020
* create component skeleton * initial commit for poll feature * fix tests * use correct event name * use correct fields for composite messages * ignore notification settings for alerts * don't show markdown notation in notifications * styling update * disable reply for composite messages * update version in message entity * no copy / no like for composite * add uid to button * show error messages * add data uie to error message * change message behaviour and markdown support for headings * chore: only string as buttonid type * notification tests and fixes * remove markdown tokens from conversationcell * cast string type * fix button styles * just one error message for all cases * Update src/script/components/asset/messageButton.ts Co-Authored-By: Michael Koppen <[email protected]> * Update src/style/components/asset/message-button.less Co-Authored-By: Michael Koppen <[email protected]> * Update src/script/entity/message/Button.ts Co-Authored-By: Michael Koppen <[email protected]> * Update src/script/entity/message/CompositeMessage.ts Co-Authored-By: Michael Koppen <[email protected]> * feat: Send status updates only to the first 500 users * remove old threshold mechanics for status updates * fix prettier stuff * less magic, easier array partitioning * add test for partition * rename isMessage_read * feat: Show members found on backend in start UI * remove async from computed * feat: Search backend for members in user list component * feat: Show members found on backend in start UI (#8510) * fix client sending * feat: Filter externals from team member search results * revert broadcast fix * fix userlist * feat: Get self member data on app start (#8515) * feat: Get self member data on app start * updateTeamMembersByIds * dont assign members * fix test Co-authored-by: AndyLnd <[email protected]> * runfix: don't fetch team mebers for non team users * Squashed commit of the following: commit aeffa4814f02b208df8cb0e9b133ecc1bd60d135 Author: AndyLnd <[email protected]> Date: Thu Apr 16 12:05:15 2020 +0200 search repository is not scoped * fix parameter type * retrigger travis * sort members found on backend alpahbetically into locals * feat: Check for missing team member when no clients are left (WEBAPP-6760) (#8562) * runfix: Remove unused import * feat: Set maximum broadcast receivers to 500 (#8574) * feat: Report missing broadcst clients only for receivers (#8597) * chore: Upgrade @wireapp/core to 16.6.9 * chore: Upgrade @wireapp/core to 16.6.10 * feat: Dynamic member loading * fix tests * feat: Load all members on start for small teams * runfix: Don't try to fetch team members for non team users * runfix: Block member requests if no team id * runfix: only add users to members that are actually members * update based on pr comments Co-authored-by: Michael Koppen <[email protected]> Co-authored-by: Benny Neugebauer <[email protected]> Co-authored-by: Florian Keller <[email protected]> Co-authored-by: Florian Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.