Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display the correct warning when team setting does not allow guest links [WPB-6906] #17120

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Mar 21, 2024

BugWPB-6906 [Web] Guest links not allowed prompt is wrong

Description

The condition to display the message that guest link are disabled for the current team or for another team was wrong.

This PR fixes it.

Before

image

After

image

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc requested review from otto-the-bot and a team as code owners March 21, 2024 14:06
@atomrc atomrc changed the title fix: Display the correct warning when team setting does not allow guest links fix: Display the correct warning when team setting does not allow guest links [WPB-6906] Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.13%. Comparing base (9c0c156) to head (71ce3ff).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17120      +/-   ##
==========================================
- Coverage   46.13%   46.13%   -0.01%     
==========================================
  Files         747      747              
  Lines       24554    24555       +1     
  Branches     5611     5611              
==========================================
  Hits        11329    11329              
- Misses      11792    11793       +1     
  Partials     1433     1433              

@atomrc atomrc merged commit 6a0b1cf into dev Mar 21, 2024
13 checks passed
@atomrc atomrc deleted the fix/guest-link-copy branch March 21, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants