Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reaction popover and messages padding #16833

Merged

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Feb 14, 2024

Description

Changed right sidebar overlapping to the message wrapper, now we have slide animation while opening right sidebar.
Changed paddings between messages.
Fixed not centered position in top bar, while showing alert about turning on notifications.

Screenshots/Screencast (for UI changes)

image

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/q1-2024@8dec931). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/q1-2024   #16833   +/-   ##
==================================================
  Coverage                   ?   45.85%           
==================================================
  Files                      ?      746           
  Lines                      ?    24517           
  Branches                   ?     5601           
==================================================
  Hits                       ?    11242           
  Misses                     ?    11837           
  Partials                   ?     1438           

@przemvs przemvs merged commit e3c126e into release/q1-2024 Feb 14, 2024
11 checks passed
@przemvs przemvs deleted the feat/WPB-6322-reaction-popover-and-messages-padding branch February 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants