fix: backend sends gracePeriod in seconds instead of ms #16132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ToDo: Do these values need to te able to be updated? Should we use a singleton with update fn? | ||
| this.discoveryUrl = discoveryUrl; | ||
| this.gracePeriodInMS = gracePeriodInMS; | ||
| this.gracePeriodInMS = gracePeriodInSeconds * 1000; |
There was a problem hiding this comment.
suggestion: good to use 1000 as const
There was a problem hiding this comment.
There is a util for that. Look for TIME_IN_MILLIS.SECOND ;)
aweiss-dev
changed the title
atomrc
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the E2EI GracePeriod. The backend sends the GracePeriod in Seconds, I did initially think it would be MS, they get converted now.