Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use qualified endpoints for updating conversation properties [WPB-4492] #15751

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Sep 6, 2023

TaskWPB-4492 [Web] cannot set notification status on a conversation owned by a different backend

Description

This will make sure that the following actions are possible on remote federated conversations:

  • update notification preferences
  • change timer setting
  • archive

see wireapp/wire-web-packages#5467

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #15751 (97219bb) into dev (caae58e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #15751      +/-   ##
==========================================
- Coverage   44.50%   44.48%   -0.03%     
==========================================
  Files         672      672              
  Lines       22703    22703              
  Branches     5167     5167              
==========================================
- Hits        10105    10100       -5     
- Misses      11310    11314       +4     
- Partials     1288     1289       +1     

@atomrc atomrc merged commit 55602f5 into dev Sep 6, 2023
@atomrc atomrc deleted the fix/self-conversation-qualified branch September 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants