feat: update yarn to v2, update typescript #4402
Conversation
| @@ -49,7 +49,7 @@ Collection of npm modules created by Wire's web team: | |||
|
|
|||
| ```bash | |||
| ## Download dependencies and link packages | |||
| yarn && yarn boot | |||
| yarn | |||
There was a problem hiding this comment.
does yarn2 provides the exact same feature as lerna bootstrap? Why did we need the bootstrap before?
There was a problem hiding this comment.
as far as i understand, lerna bootstrap is from ancient times when npm had no workspaces and yarn didn't exist.
Yarn2 has a very good workspace integration that takes care of the things lerna bootstrap was supposed to do.
| "nohoist": [ | ||
| "**/@jest/**/*", | ||
| "**/@types/!(long)**/*", | ||
| "**/emotion-normalize", | ||
| "**/jest-emotion", | ||
| "**/react" | ||
| ], |
There was a problem hiding this comment.
This is yarn hoisting (decides where to place npm modules). Its handled different in yarn2 (take a look into the yarn.yml), so this code is not needed anymore (yarn actually warns you that is deprecated)
| "@wireapp/priority-queue": "1.7.0", | ||
| "@wireapp/protocol-messaging": "1.37.0", | ||
| "@wireapp/commons": "workspace:^", | ||
| "@wireapp/priority-queue": "workspace:^", |
There was a problem hiding this comment.
What is going to happen to workspace:^ when we release this on NPM?
There was a problem hiding this comment.
https://yarnpkg.com/features/workspaces/#publishing-workspaces
TLDR: Gets replaced with latest version number
This PR concentrates on workspace/tooling improvements and dependency updates.
The following has been done: