Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos homebrew dependencies and filename case #421

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

hgiasac
Copy link
Contributor

@hgiasac hgiasac commented Jul 30, 2018

This PR support for MacOS build:

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2018

CLA assistant check
All committers have signed the CLA.

@neongreen
Copy link
Contributor

How does brew install cryptobox work? Does brew know how to install local packages, or..?

@hgiasac
Copy link
Contributor Author

hgiasac commented Jul 31, 2018

@neongreen Sorry, my mistake. cryptobox doesn't exist in homebrew. The correct library is geoip

@neongreen
Copy link
Contributor

Thanks!

Can you squash the commits? The first one is not linked to your Github and our CLA bot complains about that 😔

@hgiasac hgiasac force-pushed the macos-dependency-update branch from 76f7dd9 to c83e6c6 Compare July 31, 2018 09:19
@hgiasac
Copy link
Contributor Author

hgiasac commented Jul 31, 2018

Done. Sorry about the inconvenience

@neongreen neongreen merged commit 907c0fe into wireapp:develop Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants