[WPB-9065] Rename EmailSmsSubsystem effect
#4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
approved these changes
Jul 4, 2024
pcapriotti
approved these changes
Jul 4, 2024
akshaymankar
approved these changes
Jul 4, 2024
changelog.d/5-internal/WPB-9065
Outdated
| @@ -0,0 +1 @@ | |||
| Rename effect EmailSmsSubsystem to EmailSubsystem as it has no SMS action anymore | |||
There was a problem hiding this comment.
Feel free to drop this, we never made a release anyway.
There was a problem hiding this comment.
Ok, I'm removing. But then hopefully we get to merge this PR before we cut a release!
mdimjasevic
force-pushed
the
wpb-9065/rename-email-subsys-effect
branch
from
85e01c9
to
c50243d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #4045 , all SMS functionality was removed, including from the effect
EmailSmsSubsystem. Hence this PR that only drops "Sms" from the effect name.Tracked by https://wearezeta.atlassian.net/browse/WPB-9065.
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d