Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] replace cabal.project.local template and update cabal.project #4119

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

MangoIV
Copy link
Collaborator

@MangoIV MangoIV commented Jul 3, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 3, 2024
@akshaymankar
Copy link
Member

package: * applies to all packages not just local pacakges. I think this would fail if protobuf stuff which is not provided by nix has any warnings.

@MangoIV
Copy link
Collaborator Author

MangoIV commented Jul 3, 2024

can we not overwrite in case we run into warnings for these two packages in future? i.e.
package * in general and then package proto-lens-protoc ghc-options -Wwarn?

@MangoIV
Copy link
Collaborator Author

MangoIV commented Jul 3, 2024

in fact, I deleted my cabal store and am trying to build right now, it doesn't look as though it's problematic.

@MangoIV
Copy link
Collaborator Author

MangoIV commented Jul 3, 2024

currently proto-lens-protoc and hspec-discover do not emit warnings. I have protected us against them failing in future by adding a -Wwarn flag to them. I think this should resolve the objections.

@MangoIV
Copy link
Collaborator Author

MangoIV commented Jul 3, 2024

There’s even a better option: just don’t use the package stanza at all: https://cabal.readthedocs.io/en/stable/cabal-project-description-file.html#package-configuration-options

@MangoIV MangoIV force-pushed the mangoiv/cabal-project-grooming branch from 9a0c24f to ed93408 Compare July 3, 2024 11:49
@MangoIV MangoIV merged commit b690486 into develop Jul 3, 2024
10 checks passed
@MangoIV MangoIV deleted the mangoiv/cabal-project-grooming branch July 3, 2024 13:25
@mastaab mastaab added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants