Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-5491 Log password reset errors instead of propagating them #4114

Merged
merged 2 commits into from
Jul 2, 2024
Merged

WPB-5491 Log password reset errors instead of propagating them #4114

merged 2 commits into from
Jul 2, 2024

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jul 1, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-5491

This PR is based on #4111. Rebase on develop once #4111 is merged.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 1, 2024
@battermann battermann changed the title log password reset errors instead of propagating them WPB-5491 Log password reset errors instead of propagating them Jul 1, 2024
@battermann battermann marked this pull request as ready for review July 1, 2024 10:16
MangoIV
MangoIV approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@MangoIV MangoIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Base automatically changed from WPB-9831-send-password-reset-emails-texts-using-subsystems to develop July 2, 2024 12:31
@battermann battermann force-pushed the WPB-5491-password-reset-leaks-which-email-addresses-have-account branch from 147d385 to a001f4f Compare July 2, 2024 14:03
@battermann battermann merged commit 67a5f68 into develop Jul 2, 2024
10 checks passed
@battermann battermann deleted the WPB-5491-password-reset-leaks-which-email-addresses-have-account branch July 2, 2024 14:56
@echoes-hq echoes-hq bot added echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. labels Jul 3, 2024
@zebot zebot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangoIV MangoIV MangoIV approved these changes

Assignees
No one assigned
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @MangoIV @zebot