Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ TLS #4094

Merged
merged 19 commits into from
Jun 21, 2024
Merged

RabbitMQ TLS #4094

merged 19 commits into from
Jun 21, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jun 18, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-6734

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 18, 2024
@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/gen-certs June 18, 2024 08:35
@pcapriotti pcapriotti marked this pull request as ready for review June 19, 2024 07:37
Base automatically changed from pcapriotti/gen-certs to develop June 19, 2024 09:33
battermann
battermann approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcapriotti pcapriotti merged commit e01888a into develop Jun 21, 2024
9 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/rabbit-tls branch June 21, 2024 11:59
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput Changes intended at preserving our ability to evolve the software safely and effectively label Jun 27, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security Security related changes or defects label Jun 27, 2024
@zebot zebot mentioned this pull request Jul 8, 2024
Merged
@pcapriotti pcapriotti mentioned this pull request Jul 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/security Security related changes or defects echoes: technical-roadmap/throughput Changes intended at preserving our ability to evolve the software safely and effectively ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @battermann @zebot