Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update email templates to v1.0.121. #4064

Merged
merged 6 commits into from
May 29, 2024
Merged

Update email templates to v1.0.121. #4064

merged 6 commits into from
May 29, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented May 27, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-8852

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 27, 2024
@tlebon
Copy link
Contributor

tlebon commented May 27, 2024

i noticed an issue or two, maybe we can wait until i push a new version. im just double-checking things.

@fisx fisx mentioned this pull request May 27, 2024
Merged
elland
elland approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated changes.

tlebon
tlebon requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@tlebon tlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry there still appears to be an issue with some of the translations on crowdin and i am investigating. it appears for this project our pipeline isnt overwriting them and things are still missing.

@fisx fisx mentioned this pull request May 28, 2024
Closed
2 tasks
@fisx fisx changed the title Update email templates to v1.0.110. Update email templates to v1.0.121. May 28, 2024
@fisx fisx requested a review from tlebon May 28, 2024 11:45
tlebon
tlebon approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@tlebon tlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good now

@fisx fisx merged commit 44dfa39 into develop May 29, 2024
9 checks passed
@fisx fisx deleted the email-templates-v1.0.110 branch May 29, 2024 20:09
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
@zebot zebot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlebon tlebon tlebon approved these changes

@elland elland elland approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fisx @tlebon @elland @zebot