-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias to GET /conversations/{cnv} endpoint for LH devices #2682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention is only to give legalhold access to one thing (read some information), wouldn't it be better to create another (alias) endpoint /legalhold/conversations/{cnv}
and whitelist only that? That would restrict what legalhold can do.
Good idea! @dkovacevic, would that work for you? |
75449ac
to
eef25f1
Compare
Thanks for creating the alias! |
This PR adds an alias for the endpoint
at
and permits legalhold devices access to it.
We use an alias instead of allowing
GET /conversations/{cnv}
because the nginzacl
files are not expressive enough to match only this endpoint (and not e.g.POST /conversations/join
)Checklist:
changelog.d
charts/nginz/values.yaml
deploy/services-demo/conf/nginz/nginx.conf