Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-873] Leaving MLS Conversations and Backend-side Removals #2667

Merged
merged 11 commits into from
Sep 14, 2022

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Sep 1, 2022

Tracked by https://wearezeta.atlassian.net/browse/FS-873.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic temporarily deployed to cachix September 1, 2022 20:25 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 1, 2022 20:25 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 2, 2022 09:20 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 2, 2022 09:20 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 2, 2022
@mdimjasevic mdimjasevic force-pushed the fs-873/leave-and-backend-side-removals branch from dbd0f22 to b33b18f Compare September 6, 2022 08:30
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 08:30 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 08:30 Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review September 6, 2022 08:43
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 08:47 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 08:47 Inactive
@mdimjasevic mdimjasevic marked this pull request as draft September 6, 2022 08:54
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 10:05 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 10:05 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 12:13 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 12:13 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 13:18 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 6, 2022 13:18 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 15:09 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 15:09 Inactive
@pcapriotti pcapriotti force-pushed the fs-873/leave-and-backend-side-removals branch from b115daf to 172f1d5 Compare September 6, 2022 15:09
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 15:09 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 6, 2022 15:09 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 7, 2022 05:32 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 7, 2022 05:32 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-873/leave-and-backend-side-removals branch from 7b49067 to 3b8609d Compare September 7, 2022 09:19
@mdimjasevic mdimjasevic temporarily deployed to cachix September 7, 2022 09:19 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 7, 2022 09:19 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-873/leave-and-backend-side-removals branch from 3b8609d to 1c2b60e Compare September 7, 2022 14:00
@mdimjasevic mdimjasevic temporarily deployed to cachix September 7, 2022 14:00 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 07:43 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 07:43 Inactive
@pcapriotti pcapriotti force-pushed the fs-873/leave-and-backend-side-removals branch from 3dc847e to 980bcfa Compare September 14, 2022 08:33
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 08:33 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 08:33 Inactive
Base automatically changed from mls-refactor-tests to develop September 14, 2022 09:23
@pcapriotti pcapriotti force-pushed the fs-873/leave-and-backend-side-removals branch from 980bcfa to 01ed25c Compare September 14, 2022 09:26
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 09:26 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 14, 2022 09:26 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review September 14, 2022 09:28
Copy link
Contributor Author

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcapriotti, it all looks good to me.

@pcapriotti pcapriotti merged commit abe85c6 into develop Sep 14, 2022
@pcapriotti pcapriotti deleted the fs-873/leave-and-backend-side-removals branch September 14, 2022 12:11
pcapriotti added a commit that referenced this pull request Sep 23, 2022
After #2667, when users are kicked out of a conversation, the events
being sent out would look like normal leave events. This commit restores
the previous behaviour: the events reflect the fact that the user was
kicked out, with the originating user set to the user who caused the
change that required users to be removed.
pcapriotti added a commit that referenced this pull request Sep 26, 2022
After #2667, when users are kicked out of a conversation, the events
being sent out would look like normal leave events. This commit restores
the previous behaviour: the events reflect the fact that the user was
kicked out, with the originating user set to the user who caused the
change that required users to be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants