-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS-873] Leaving MLS Conversations and Backend-side Removals #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Sep 2, 2022
mdimjasevic
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 6, 2022 08:30
dbd0f22
to
b33b18f
Compare
pcapriotti
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 6, 2022 15:09
b115daf
to
172f1d5
Compare
mdimjasevic
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 7, 2022 09:19
7b49067
to
3b8609d
Compare
mdimjasevic
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 7, 2022 14:00
3b8609d
to
1c2b60e
Compare
pcapriotti
force-pushed
the
mls-refactor-tests
branch
from
September 14, 2022 08:33
48e1504
to
33755d8
Compare
pcapriotti
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 14, 2022 08:33
3dc847e
to
980bcfa
Compare
pcapriotti
force-pushed
the
fs-873/leave-and-backend-side-removals
branch
from
September 14, 2022 09:26
980bcfa
to
01ed25c
Compare
mdimjasevic
commented
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcapriotti, it all looks good to me.
pcapriotti
approved these changes
Sep 14, 2022
2 tasks
pcapriotti
added a commit
that referenced
this pull request
Sep 23, 2022
After #2667, when users are kicked out of a conversation, the events being sent out would look like normal leave events. This commit restores the previous behaviour: the events reflect the fact that the user was kicked out, with the originating user set to the user who caused the change that required users to be removed.
pcapriotti
added a commit
that referenced
this pull request
Sep 26, 2022
After #2667, when users are kicked out of a conversation, the events being sent out would look like normal leave events. This commit restores the previous behaviour: the events reflect the fact that the user was kicked out, with the originating user set to the user who caused the change that required users to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by https://wearezeta.atlassian.net/browse/FS-873.
Checklist
changelog.d